Open
Conversation
- Remove unused struc_t and member_t variables (lines 689, 692) - Simplify DLLEXPORT macro to fix linker errors - Changes are compatible with all platforms (Windows/Mac/Linux)
fdsmlx
force-pushed
the
fix-ida9-build
branch
from
21ff277 to
85b013a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix IDA 9.0 build errors on Windows
Problem
The plugin fails to build on IDA SDK 9.0 with the following errors:
struc_tandmember_tundefined (removed in IDA 9.0)__declspec(dllimport)symbolsSolution
Removed unused variables (lines 689, 692 in ReconstructableType.cpp)
Simplified DLLEXPORT macro (Common.h)
Testing
Related Issues
Fixes #120 (IDA 9.0 Support)
Complements #121 (builds on top of @BowDown097's work)